Code

refactoring of battleship_oo2#1

Code

Open

pythonlectures wants to merge 18 commits intomasterpythonlectures/battleship:masterfrom

reviewpythonlectures/battleship:reviewCopy head branch name to clipboard

Commits

Commits on Aug 11, 2018

• refactoring of battleship_oo2

  Show description for ad3f119
  maveec

  committed
  ad3f119

  Copy full SHA for ad3f119

Commits on Aug 12, 2018

• refactoring of battleship_oo2

  Show description for d1a7842
  maveec

  committed
  d1a7842

  Copy full SHA for d1a7842

• test to check file ending in github

  maveec

  committed
  f5fcf86

  Copy full SHA for f5fcf86

Commits on Aug 21, 2018

• refactoring of battleship_oo2_test.py

  Show description for c96657b
  maveec

  committed
  c96657b

  Copy full SHA for c96657b

• bug fixing

  maveec

  committed
  6129f14

  Copy full SHA for 6129f14

• message taken out to Game

  maveec

  committed
  08812fc

  Copy full SHA for 08812fc

• made everything private

  maveec

  committed
  15d28de

  Copy full SHA for 15d28de

Commits on Sep 1, 2018

• made methods private

  maveec

  committed
  9d24912

  Copy full SHA for 9d24912

• Use of Enum for cellStatus

  maveec

  committed
  47a85b5

  Copy full SHA for 47a85b5

• add_shot removed

  Show description for 7b6c222
  maveec

  committed
  7b6c222

  Copy full SHA for 7b6c222

• code formatting

  maveec

  committed
  338cee4

  Copy full SHA for 338cee4

• lined battleship_precedural2 to battleship_oop2_test

  maveec

  committed
  dd1ec03

  Copy full SHA for dd1ec03

• CRLF for battleship_oo2

  maveec

  committed
  a6eda42

  Copy full SHA for a6eda42

Commits on Sep 6, 2018

• cleaned 002 test

  pythonlectures

  committed
  6c2c202

  Copy full SHA for 6c2c202

Commits on Sep 8, 2018

• added error handling for input

  pythonlectures

  committed
  c0938ee

  Copy full SHA for c0938ee

• variant for tests. still not sure when to use fixtures and when to aggregate asserts in one function

  pythonlectures

  committed
  62532d9

  Copy full SHA for 62532d9

• added README.md file

  pythonlectures

  committed
  a0ad7ec

  Copy full SHA for a0ad7ec

Commits on Sep 9, 2018

• packaged tests folder

  Show description for 1df5c30
  pythonlectures

  committed
  1df5c30

  Copy full SHA for 1df5c30