Simplify aiida notebook through one-shot WG creation #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously first created all the tasks without links and then added the links "manually" at the end. This was done to obtain the same order of tasks as when exporting from the jobflow notebooks—for side-by-side comparison and debugging during development.
However, this was overly complicated and is different from how one would typically construct a WorkGraph, where one can directly pass the output socket of the first task to the input of the second task when creating the second task. This simplifies the creation of the EOS WG, as, for example, we don't require two for-loops over the strains anymore (previously, one was used to add the tasks, the other one to add the links once all the tasks had been added in the desired order).
The various
pickle_<something>_task
s are still a bit annoying, as one would usually just pass these values as inputs when running/submitting the WG, but we need them to obtain input data nodes in the exported universal representation.