Skip to content

Add pydantic validation #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 11, 2025
Merged

Add pydantic validation #97

merged 8 commits into from
May 11, 2025

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen mentioned this pull request May 11, 2025
@jan-janssen jan-janssen merged commit e0c726f into main May 11, 2025
8 checks passed
@jan-janssen jan-janssen deleted the pydantic branch May 11, 2025 21:37
@GeigerJ2
Copy link
Collaborator

GeigerJ2 commented May 14, 2025

Thanks for cleaning up from #94 and making this PR, @jan-janssen. Could we use PwdInputNode rather than PythonWorkflowDefinitionInputNode? Same for the other model classes? Otherwise, the names are just very long, I feel.

@jan-janssen
Copy link
Member Author

@GeigerJ2 My intention was to be explicit when somebody imports the class in a different code or validates a JSON file. Still the more I think about it the more I wonder if we need the prefix at all or if we could just name it InputNode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants