Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.8 (#136) and use Cython if available (#134) #137

Merged
merged 3 commits into from
Nov 4, 2019

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Nov 3, 2019

Python 3.8 failed to install cytoolz b/c the .c files created by Cython were not forward-compatible. This justifies always using Cython if available.

Also, add Cython as an optional dependency via extras_require in setup.py. This should allow pip install "cytoolz[cython]" to do the right thing.

Python 3.8 failed to install cytoolz b/c the .c files created by Cython were not
forward-compatible.  This justifies always using Cython if available.

Also, add Cython as an optional dependency via `extras_require` in setup.py.
This should allow `pip install "cytoolz[cython]"` to do the right thing.
@eriknw
Copy link
Member Author

eriknw commented Nov 3, 2019

Rules are as follows (apply first applicable rule):

  1. If --no-cython or --without-cython are used, then only build from .*c files.
  2. If this is a dev version, then cythonize only the files that have changed.
  3. If --cython or --with-cython are used, then force cythonize all files.
  4. If no arguments are passed, then force cythonize all files if Cython is available, else build from *.c files.

By forcing cythonization of all files (except in dev) if Cython is available, we avoid the case where the generated *.c files are not forward-compatible.

@eriknw eriknw merged commit 04d3a7f into pytoolz:master Nov 4, 2019
ossdev07 pushed a commit to ossdev07/cytoolz that referenced this pull request Dec 31, 2019
Test Python 3.8 (pytoolz#136) and use Cython if available (pytoolz#134)
compojoom added a commit to trustlines-protocol/py-eth-index that referenced this pull request Aug 21, 2020
Cytools was failing to compile on mac with python 3.8.5. The problem appears to have been fixed in 0.10.1 with this PR: pytoolz/cytoolz#137
cducrest pushed a commit to trustlines-protocol/py-eth-index that referenced this pull request Aug 21, 2020
Cytools was failing to compile on mac with python 3.8.5. The problem appears to have been fixed in 0.10.1 with this PR: pytoolz/cytoolz#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant