Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Python 3.13 #587

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Test against Python 3.13 #587

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3796326
Test against Python 3.13
jrbourbeau Sep 27, 2024
d7b37a5
Run CI more
jrbourbeau Sep 27, 2024
be4318c
Merge branch 'master' of https://github.com/pytoolz/toolz into test-313
jrbourbeau Sep 27, 2024
fe31e9c
Revert
jrbourbeau Sep 27, 2024
60769d3
Don't fail
jrbourbeau Sep 27, 2024
f343824
Update token usage
jrbourbeau Sep 27, 2024
f18ca86
Typo
jrbourbeau Sep 27, 2024
a52ee97
Bump version
jrbourbeau Sep 27, 2024
74bfc04
Remove unused coverage line
jrbourbeau Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
- "3.10"
- "3.11"
- "3.12"
- "3.13-dev"
- "pypy-3.8"
- "pypy-3.9"
- "pypy-3.10"
Expand All @@ -42,9 +43,8 @@ jobs:
if: (! contains(matrix.python-version, 'pypy'))
run: |
coverage xml
coverage report --show-missing --fail-under=100
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line here as it requires every single CI build to have 100% coverage. This isn't quite right in cases when there are Python version-specific lines of code (which we have in toolz).

Instead, let's merge coverage reports across all CI build with codecov to make sure that, summed across all Python versions, we have 100% coverage.

- name: codecov
if: (! contains(matrix.python-version, 'pypy'))
uses: codecov/codecov-action@v3
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
Comment on lines +48 to +50
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were having coverage report upload issues, so I had to bump the version of the codecov action being used here