-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimzed backward pass for ROCm devices (#3367) #3468
base: main
Are you sure you want to change the base?
Conversation
No ciflow labels are configured for this repo. |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request was exported from Phabricator. Differential Revision: D66310520 |
This pull request was exported from Phabricator. Differential Revision: D66310520 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D66310520 |
3a0eb42
to
5937d2f
Compare
Summary: X-link: facebookresearch/FBGEMM#552 X-link: facebookresearch/FBGEMM#491 Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Reviewed By: leitian Differential Revision: D66310520 Pulled By: q10
This pull request was exported from Phabricator. Differential Revision: D66310520 |
Summary: X-link: facebookresearch/FBGEMM#552 X-link: facebookresearch/FBGEMM#491 Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Reviewed By: leitian Differential Revision: D66310520 Pulled By: q10
This pull request was exported from Phabricator. Differential Revision: D66310520 |
Summary: X-link: facebookresearch/FBGEMM#552 X-link: facebookresearch/FBGEMM#491 Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Reviewed By: leitian Differential Revision: D66310520 Pulled By: q10
This pull request was exported from Phabricator. Differential Revision: D66310520 |
Hi @q10! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/491
Added optimized implementation of backward pass for ROCm devices. Currently support not nobag mode, rowwise_adagrad optimizer with non-mixed dimensions in [64, 128, 160, 192].
Reviewed By: leitian
Differential Revision: D66310520
Pulled By: q10
This is a re-export of #3367 with additional changes added to make the PR build correctly