Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimzed backward pass for ROCm devices (#3367) #3468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Dec 6, 2024

Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/491

Added optimized implementation of backward pass for ROCm devices. Currently support not nobag mode, rowwise_adagrad optimizer with non-mixed dimensions in [64, 128, 160, 192].

Reviewed By: leitian

Differential Revision: D66310520

Pulled By: q10

This is a re-export of #3367 with additional changes added to make the PR build correctly

Copy link

pytorch-bot bot commented Dec 6, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 898d91d
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67576d0ca6ff120008b5de20
😎 Deploy Preview https://deploy-preview-3468--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66310520

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66310520

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66310520

@q10 q10 force-pushed the export-D66310520 branch 2 times, most recently from 3a0eb42 to 5937d2f Compare December 6, 2024 02:27
q10 pushed a commit to q10/FBGEMM that referenced this pull request Dec 6, 2024
Summary:
X-link: facebookresearch/FBGEMM#552


X-link: facebookresearch/FBGEMM#491

Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192].


Reviewed By: leitian

Differential Revision: D66310520

Pulled By: q10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66310520

@q10 q10 force-pushed the export-D66310520 branch from 5937d2f to 28225de Compare December 6, 2024 20:07
q10 pushed a commit to q10/FBGEMM that referenced this pull request Dec 6, 2024
Summary:
X-link: facebookresearch/FBGEMM#552


X-link: facebookresearch/FBGEMM#491

Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192].


Reviewed By: leitian

Differential Revision: D66310520

Pulled By: q10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66310520

Summary:
X-link: facebookresearch/FBGEMM#552


X-link: facebookresearch/FBGEMM#491

Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192].


Reviewed By: leitian

Differential Revision: D66310520

Pulled By: q10
@q10 q10 force-pushed the export-D66310520 branch from 28225de to 898d91d Compare December 9, 2024 22:19
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66310520

@facebook-github-bot
Copy link
Contributor

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants