Back out "Manual loop unroll for rocm inference" #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Original commit changeset: 66ba86adbd5e Original Phabricator Diff: D66563556 Differential Revision: D67246937
|
No ciflow labels are configured for this repo. |
|
This pull request was exported from Phabricator. Differential Revision: D67246937 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Context for the AMD folks: There was an internal perf benchmark that regressed and seemed to have pointed to PR 3506, presumably because the code was not tuned for the nobag TBE case. However, after some discussions, it was concluded that the regression is within noise, and that this revert PR will not be landed until more detailed tests confirm this hypothesis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: 66ba86adbd5e
Original Phabricator Diff: D66563556
Differential Revision: D67246937