mimic mx4 in nvfp4 native #4970
Open
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary: X-link: facebookresearch/FBGEMM#1987 Use Native NVFP4 matmul to mimic MX4 matmul. ``` global_scale = 1.0 fp32_local_scale = local_amax / 4.0 * global_scale nvfp4_local_scale = fp8_e4m3(fp32_to_e8m0(fp32_local_scale)) ``` **Verify Correctness** Output from the buck2 command in test plan > I1001 103514.172 numerics_bench.py:310] Numeric metrics for mx_quant mx4 symm,e8m0,pow2max,even,none,e2m1,nearest,1x16,0 use_triton=True I1001 103514.173 numerics_bench.py:115] runtime: 1.221 ms. I1001 103514.173 numerics_bench.py:116] TFLOPS: 379.941. I1001 103514.173 numerics_bench.py:117] output_abs_err_bf16: 0.013. I1001 103514.173 numerics_bench.py:118] output_rel_err_bf16: 1.672. I1001 103514.173 numerics_bench.py:119] output_sqnr_bf16: 16.094 dB. I1001 103514.173 numerics_bench.py:121] output_abs_err_mx4: 0.000. I1001 103514.174 numerics_bench.py:124] output_rel_err_mx4: 0.000. I1001 103517.503 numerics_bench.py:310] Numeric metrics for native_mx4_as_nvfp4 mx4 symm,e8m0,pow2max,even,none,e2m1,nearest,1x16,0 I1001 103517.503 numerics_bench.py:115] runtime: 0.317 ms. I1001 103517.504 numerics_bench.py:116] TFLOPS: 1463.532. I1001 103517.504 numerics_bench.py:117] output_abs_err_bf16: 0.013. I1001 103517.504 numerics_bench.py:118] output_rel_err_bf16: 1.672. I1001 103517.504 numerics_bench.py:119] output_sqnr_bf16: 16.094 dB. I1001 103517.504 numerics_bench.py:121] output_abs_err_mx4: 0.000. I1001 103517.504 numerics_bench.py:124] output_rel_err_mx4: 0.000. Also verify the outputs match at bit-level by comparing the outputs in bento N8236690 Reviewed By: ghjeong12 Differential Revision: D83677495
pyjhzwh
force-pushed
the
export-D83677495
branch
from
d755074 to
97ec628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use Native NVFP4 matmul to mimic MX4 matmul.
Verify Correctness
Output from the buck2 command in test plan
Also verify the outputs match at bit-level by comparing the outputs in bento N8236690
Differential Revision: D83677495