fix integer overflow problem #5051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#2055 When token size is very big, the integer multiplication will lead to integer overflow therefore lead to a cuda memory access error. Reviewed By: royren622 Differential Revision: D85330676
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has been merged in f849dcd. |
Bernard-Liu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Oct 29, 2025
Summary: Pull Request resolved: pytorch#5051 X-link: https://github.com/facebookresearch/FBGEMM/pull/2055 When token size is very big, the integer multiplication will lead to integer overflow therefore lead to a cuda memory access error. Reviewed By: royren622 Differential Revision: D85330676 fbshipit-source-id: 51a5f61ed52f43358b61f4e689b33b95d051f987
Bernard-Liu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Oct 31, 2025
Summary: Pull Request resolved: pytorch#5051 X-link: https://github.com/facebookresearch/FBGEMM/pull/2055 When token size is very big, the integer multiplication will lead to integer overflow therefore lead to a cuda memory access error. Reviewed By: royren622 Differential Revision: D85330676 fbshipit-source-id: 51a5f61ed52f43358b61f4e689b33b95d051f987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2055
When token size is very big, the integer multiplication will lead to integer overflow therefore lead to a cuda memory access error.
Reviewed By: royren622
Differential Revision: D85330676