-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodule asmjit #520
Conversation
* replace use of deprecated APIs
This reverts commit 218d198.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianyuh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@luncliff May I know the reason for asmjit version upgrade? |
I'd like to support this project as a package of https://github.com/microsoft/vcpkg. |
@dskhudia, Is there anything I can do for this PR? Will be glad to hear from the maintainers :) |
We have to upgrade asmjit for our internal code base before I can land this PR. Unfortunately I will have to create a new PR with these changes. Is it ok with you if we close this PR and land in a new PR? |
Of course. Feel free to close this for the next PR :) |
Changes
asmjit
to asmjit/asmjit@5a5fb8aAddmacos
executor for build checkOh, I didn't know
macos
requires a pricing plan...Related Issues?
The changes are for microsoft/vcpkg#16346