Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule asmjit #520

Closed
wants to merge 3 commits into from
Closed

Update submodule asmjit #520

wants to merge 3 commits into from

Conversation

luncliff
Copy link

@luncliff luncliff commented Feb 24, 2021

Changes

  • Update submodule asmjit to asmjit/asmjit@5a5fb8a
    • Replaced deprecated API usage
  • Add macos executor for build check
    Oh, I didn't know macos requires a pricing plan...

Related Issues?

The changes are for microsoft/vcpkg#16346

@luncliff luncliff closed this Feb 24, 2021
@luncliff luncliff deleted the update/asmjit branch February 24, 2021 02:49
@luncliff luncliff restored the update/asmjit branch February 24, 2021 02:49
@luncliff luncliff reopened this Feb 24, 2021
@luncliff luncliff changed the title Update submodule asmjit and Circle CI configuration Update submodule asmjit Feb 24, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianyuh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dskhudia
Copy link
Contributor

@luncliff May I know the reason for asmjit version upgrade?

@luncliff
Copy link
Author

luncliff commented Feb 24, 2021

@luncliff May I know the reason for asmjit version upgrade?

I'd like to support this project as a package of https://github.com/microsoft/vcpkg.
It already supports asmjit, and it uses a later commit than the current master's submodule reference.

@luncliff
Copy link
Author

luncliff commented Mar 5, 2021

@dskhudia, Is there anything I can do for this PR? Will be glad to hear from the maintainers :)

@dskhudia
Copy link
Contributor

dskhudia commented Mar 5, 2021

We have to upgrade asmjit for our internal code base before I can land this PR. Unfortunately I will have to create a new PR with these changes. Is it ok with you if we close this PR and land in a new PR?

@luncliff
Copy link
Author

luncliff commented Mar 5, 2021

Of course. Feel free to close this for the next PR :)

@dskhudia
Copy link
Contributor

Thanks a lot @luncliff for you PR. I have incorporated your changes in #538
Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants