Skip to content

✨[Feature] Centralize defaults for compilation within core #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gs-olive opened this issue Feb 1, 2023 · 1 comment
Closed

✨[Feature] Centralize defaults for compilation within core #1644

gs-olive opened this issue Feb 1, 2023 · 1 comment
Assignees
Labels
component: core Issues re: The core compiler feature request New feature or request No Activity

Comments

@gs-olive
Copy link
Collaborator

gs-olive commented Feb 1, 2023

Overview

Define all default values used for compile functions within a centralized location within the core library. Specifically, for the TS path which connects to the core library through Python and C++ APIs, the defaults should be located in a centralized location to avoid confusion with differing values between Python and C++ and to allow other functions within core to use these values.

Example

min_block_size will be used as an example of a compilation field for which the defaults exist in multiple locations. Specifically, for Python:


For C++:
uint64_t min_block_size = 3;

Both of these fields ultimately populate an entry in the internal PartitioningInfo structure, which is common to both APIs. Thus, code understandability would be improved by storing such defaults in a single location. Additionally, there are times when other functions could benefit from using these defaults. For example, in partitioning, there is a specific case in PR #1599 where the default min_block_size is needed, but the value cannot be directly accessed easily, making the code less adaptable.

@github-actions
Copy link

github-actions bot commented May 4, 2023

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Issues re: The core compiler feature request New feature or request No Activity
Projects
None yet
Development

No branches or pull requests

3 participants