Skip to content

feat: Upgrade TensorRT to 8.4 EA #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2022
Merged

feat: Upgrade TensorRT to 8.4 EA #1158

merged 2 commits into from
Jul 16, 2022

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Jul 1, 2022

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

Description

Upgrade TensorRT to 8.4 EA

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044
feat: Upgrade TensorRT to 8.4 EA
7266cad 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044 peri044 requested a review from narendasan July 1, 2022 22:27
@github-actions github-actions bot added component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Jul 1, 2022
@peri044 peri044 added release: patch This change needs to go out as a patch to the current version and removed component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: build system Issues re: Build system cla signed labels Jul 1, 2022
This was referenced Jul 6, 2022
Merged
Closed
narendasan
narendasan requested changes Jul 7, 2022
View reviewed changes
core/conversion/converters/converter_util.cpp
auto casted_tensor = id_layer->getOutput(0);
casted_tensor->setType(dtype);
// layer->setOutputType should be used for casting and not manually setting output_tensor->setType()
id_layer->setOutputType(0, dtype);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peri044 casted_tensor is returned by this function so right now there is a compilation failure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@peri044
chore: Fix missing return casted tensor
5da47c1 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@github-actions github-actions bot added component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Jul 7, 2022
@narendasan narendasan merged commit c2e396a into release/1.1 Jul 16, 2022
@narendasan narendasan deleted the trt_8.4_rel_1.1 branch July 16, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan requested changes

Assignees
No one assigned
Labels
cla signed component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests release: patch This change needs to go out as a patch to the current version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peri044 @narendasan @facebook-github-bot