Reorg docs and fix css for sphix-gallery examples #1967

narendasan · 2023-05-31T22:45:13Z

Description

Reorgs some files and fixes the CSS for the gallery

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project (You can use the linters)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas and hacks
I have made corresponding changes to the documentation
I have added tests to verify my fix or my feature
New and existing unit tests pass locally with my changes
I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

gs-olive

The changes improve the organization and look of the Tutorials greatly. I wonder if the thumbnails could be adapted to include some sort of download/other data instead of linking to the same hyperlinked pages as above. See the bottom of this scikit-learn examples page, for instance.

gs-olive · 2023-06-01T04:19:06Z

examples/dynamo/README.rst

- `dynamo_compile_resnet_example.py <./dynamo_compile_resnet_example.html>`_: Example showcasing compilation of ResNet model
- `dynamo_compile_transformers_example.py <./dynamo_compile_transformers_example.html>`_: Example showcasing compilation of transformer-based model
- `dynamo_compile_advanced_usage.py <./dynamo_compile_advanced_usage.html>`_: Advanced usage including making a custom backend to use directly with the `torch.compile` API
+* :ref:`dynamo_compile_resnet`: Compiling a ResNet model using the Dyanmo Compile Frontend for ``torch_tensorrt.compile``


Minor typo (replace "Dyanmo" with "Dynamo"). Also should torch_tensorrt.compile be torch.compile? For example:

Compiling a ResNet model using the Dynamo Compile Frontend for torch.compile

The example uses torch_tensorrt.compile right?

gs-olive · 2023-06-01T04:21:04Z

examples/dynamo/README.rst

- `dynamo_compile_transformers_example.py <./dynamo_compile_transformers_example.html>`_: Example showcasing compilation of transformer-based model
- `dynamo_compile_advanced_usage.py <./dynamo_compile_advanced_usage.html>`_: Advanced usage including making a custom backend to use directly with the `torch.compile` API
+* :ref:`dynamo_compile_resnet`: Compiling a ResNet model using the Dyanmo Compile Frontend for ``torch_tensorrt.compile``
+* :ref:`torch_compile_transformer`: Compiling a Transformer model using ``torch.compile``


Since the transformers script is nearly the same as the Resnet script, except for the model, this could instead be:

Compiling a Transformer model using the Dynamo Compile Frontend for torch.compile

Id like for the Transformer script to use the torch.compile interface

gs-olive · 2023-06-01T04:21:42Z

examples/dynamo/dynamo_compile_resnet_example.py

-=========================
+.. _dynamo_compile_resnet:
+
+Compiling ResNet using the Torch-TensorRT Dyanmo Frontend


See comment in examples/dynamo/README.rst

gs-olive · 2023-06-01T04:21:52Z

examples/dynamo/dynamo_compile_transformers_example.py

-=========================
+.. _torch_compile_transformer:
+
+Compiling a Transformer using torch.compile and TensorRT


See comment in examples/dynamo/README.rst

docsrc/_static/css/custom.css

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

render properly Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

gs-olive · 2023-07-25T17:55:04Z

examples/dynamo/README.rst

- `dynamo_compile_resnet_example.py <./dynamo_compile_resnet_example.html>`_: Example showcasing compilation of ResNet model
- `dynamo_compile_transformers_example.py <./dynamo_compile_transformers_example.html>`_: Example showcasing compilation of transformer-based model
- `dynamo_compile_advanced_usage.py <./dynamo_compile_advanced_usage.html>`_: Advanced usage including making a custom backend to use directly with the `torch.compile` API
+* :ref:`dynamo_compile_resnet`: Compiling a ResNet model using the Dynamo Compile Frontend for ``torch_tensorrt.compile``


Needs rename, Dynamo Compile now means something else in the torch_tensorrt context

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

facebook-github-bot added the cla signed label May 31, 2023

github-actions bot added the documentation Improvements or additions to documentation label May 31, 2023

narendasan force-pushed the dynamo_examples_gallery branch from 33e63e0 to e3bb744 Compare May 31, 2023 23:20

github-actions bot approved these changes May 31, 2023

View reviewed changes

gs-olive reviewed Jun 1, 2023

View reviewed changes

gs-olive mentioned this pull request Jun 1, 2023

feat: Prototype Module-Acceleration in Dynamo #1921

Closed

github-actions bot approved these changes Jun 1, 2023

View reviewed changes

gs-olive force-pushed the dynamo_torch_compile_examples branch 6 times, most recently from c10c4ec to 0f712bd Compare June 2, 2023 20:00

narendasan force-pushed the dynamo_examples_gallery branch from 3a4840f to 966d9fc Compare June 7, 2023 20:18

github-actions bot approved these changes Jun 7, 2023

View reviewed changes

gs-olive force-pushed the dynamo_torch_compile_examples branch 4 times, most recently from d333291 to 9588d68 Compare June 14, 2023 00:36

gs-olive force-pushed the dynamo_torch_compile_examples branch 3 times, most recently from ace988f to 764a469 Compare June 21, 2023 00:52

gs-olive force-pushed the dynamo_torch_compile_examples branch 3 times, most recently from f5af0a1 to 9c026a6 Compare June 29, 2023 00:51

gs-olive force-pushed the dynamo_torch_compile_examples branch 2 times, most recently from 1410206 to 94a7942 Compare July 12, 2023 17:21

gs-olive force-pushed the dynamo_torch_compile_examples branch from 94a7942 to 7e5f96c Compare July 12, 2023 17:29

gs-olive force-pushed the dynamo_examples_gallery branch from 966d9fc to 2684dd9 Compare July 12, 2023 17:30

github-actions bot approved these changes Jul 12, 2023

View reviewed changes

gs-olive force-pushed the dynamo_torch_compile_examples branch from 407c299 to c64566a Compare July 21, 2023 21:40

narendasan added 2 commits July 25, 2023 10:35

refactor: Fixing the CSS for the gallery and reorging the examples to

0ac791f

render properly Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

refactor: using dynamic sizing for css and some typos

ec35106

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

gs-olive force-pushed the dynamo_examples_gallery branch from 2684dd9 to ec35106 Compare July 25, 2023 17:35

github-actions bot approved these changes Jul 25, 2023

View reviewed changes

gs-olive reviewed Jul 25, 2023

View reviewed changes

gs-olive merged commit 9a91fb8 into dynamo_torch_compile_examples Jul 25, 2023

gs-olive pushed a commit that referenced this pull request Jul 25, 2023

Reorg docs and fix css for sphix-gallery examples (#1967)

4141601

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

gs-olive pushed a commit that referenced this pull request Aug 1, 2023

Reorg docs and fix css for sphix-gallery examples (#1967)

0fb56e8

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

gs-olive pushed a commit that referenced this pull request Aug 2, 2023

Reorg docs and fix css for sphix-gallery examples (#1967)

968aca4

Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>

Reorg docs and fix css for sphix-gallery examples #1967

Reorg docs and fix css for sphix-gallery examples #1967

Uh oh!

Conversation

narendasan commented May 31, 2023

Description

Type of change

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

gs-olive left a comment

Choose a reason for hiding this comment

Uh oh!

gs-olive Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

narendasan Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

gs-olive Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

narendasan Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

gs-olive Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

gs-olive Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

gs-olive Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants