feat: Add support for general-purpose function acceleration in Dynamo [6 / x] #1980

gs-olive · 2023-06-05T17:01:28Z

Description

Add functionality for advanced exclusion of both function and module-type nodes in Torch-TRT
Add sample exclusion for torch.einsum function which can be accelerated as a single unit via TRT
Add utilities and improve module and function-level exclusion mechanisms
Add test cases for new exclusion mechanism

Fixes #1959

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ x ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan

LGTM

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

- Add functionality for advanced exclusion of both function and module-type nodes in Torch-TRT - Add sample exclusion for `torch.einsum` function which can be accelerated as a single unit via TRT - Add utilities and improve module and function-level exclusion mechanisms - Add test cases for new exclusion mechanism

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

… [6 / x] (#1980)

gs-olive added component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels Jun 5, 2023

gs-olive requested a review from narendasan June 5, 2023 17:01

gs-olive self-assigned this Jun 5, 2023

facebook-github-bot added the cla signed label Jun 5, 2023

github-actions bot added the component: api [Python] Issues re: Python API label Jun 5, 2023

github-actions bot approved these changes Jun 5, 2023

View reviewed changes

gs-olive mentioned this pull request Jun 5, 2023

feat/fix: Add support for general-purpose function exclusion in Dynamo #1968

Closed

gs-olive force-pushed the dynamo_module_level_acceleration branch from 80b898a to d235c0f Compare June 5, 2023 17:19

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from a3dd0c8 to 2003b07 Compare June 5, 2023 17:21

github-actions bot approved these changes Jun 5, 2023

View reviewed changes

gs-olive mentioned this pull request Jun 5, 2023

Centralize converters for MaxPool1D and einsum #1985

Closed

narendasan approved these changes Jun 7, 2023

View reviewed changes

gs-olive force-pushed the dynamo_module_level_acceleration branch from d235c0f to a0ff354 Compare June 8, 2023 20:12

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from 2003b07 to 9e805d1 Compare June 8, 2023 20:14

gs-olive changed the title ~~feat: Add support for general-purpose function exclusion in Dynamo [5 / x]~~ feat: Add support for general-purpose function exclusion in Dynamo [8 / x] Jun 8, 2023

github-actions bot approved these changes Jun 8, 2023

View reviewed changes

gs-olive force-pushed the dynamo_module_level_acceleration branch from a0ff354 to b16d17b Compare June 8, 2023 23:30

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from 9e805d1 to 36989b8 Compare June 8, 2023 23:31

github-actions bot approved these changes Jun 8, 2023

View reviewed changes

gs-olive force-pushed the dynamo_module_level_acceleration branch from b16d17b to 54843d3 Compare June 9, 2023 04:10

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from 36989b8 to 50ce3ed Compare June 9, 2023 04:10

github-actions bot approved these changes Jun 9, 2023

View reviewed changes

gs-olive force-pushed the dynamo_module_level_acceleration branch from 54843d3 to c0715f2 Compare June 14, 2023 00:38

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from 50ce3ed to 7f8eacb Compare June 14, 2023 00:39

github-actions bot approved these changes Jun 14, 2023

View reviewed changes

gs-olive changed the title ~~feat: Add support for general-purpose function exclusion in Dynamo [8 / x]~~ feat: Add support for general-purpose function exclusion in Dynamo [6 / x] Jun 14, 2023

gs-olive mentioned this pull request Jun 20, 2023

Add example scripts for module/function level acceleration #1984

Closed

gs-olive force-pushed the dynamo_module_level_acceleration branch from c0715f2 to 57215f1 Compare June 21, 2023 00:56

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from 7f8eacb to 97d4c5b Compare June 21, 2023 00:57

github-actions bot approved these changes Jun 21, 2023

View reviewed changes

gs-olive force-pushed the dynamo_module_level_acceleration branch from 57215f1 to fbe12e3 Compare June 23, 2023 03:19

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from 97d4c5b to 5e393bc Compare June 23, 2023 03:20

github-actions bot approved these changes Jun 23, 2023

View reviewed changes

gs-olive changed the title ~~feat: Add support for general-purpose function exclusion in Dynamo [6 / x]~~ feat: Add support for general-purpose function acceleration in Dynamo [6 / x] Jun 26, 2023

gs-olive force-pushed the dynamo_module_level_acceleration branch from fbe12e3 to 7e2388f Compare June 28, 2023 19:48

gs-olive force-pushed the dynamo_general_purpose_acceleration branch from 5e393bc to 00a20c1 Compare June 28, 2023 19:49

github-actions bot approved these changes Jun 28, 2023

View reviewed changes

gs-olive merged commit f26ca80 into dynamo_module_level_acceleration Jun 29, 2023

gs-olive deleted the dynamo_general_purpose_acceleration branch June 29, 2023 00:52

gs-olive added a commit that referenced this pull request Jun 29, 2023

feat: Add support for general-purpose function acceleration in Dynamo…

c9f06fc

… [6 / x] (#1980)

gs-olive mentioned this pull request Aug 29, 2023

✨[Feature] Exclude key functions from tracing during AOT #1959

Closed

feat: Add support for general-purpose function acceleration in Dynamo [6 / x] #1980

feat: Add support for general-purpose function acceleration in Dynamo [6 / x] #1980

Uh oh!

Conversation

gs-olive commented Jun 5, 2023

Description

Type of change

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

narendasan left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants