Skip to content

fix: Repair input range on BERT inputs for CI #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix: Repair input range on BERT inputs for CI #2017

merged 1 commit into from
Jun 13, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Update range on BERT module inputs to respect input/embedding indexing restrictions
  • Fix failing CI test with BERT on TorchScript path

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • CI validation
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Repair input range on BERT inputs for CI
7bf411f 
- Update range on BERT module inputs to respect input/embedding indexing
restrictions
- Fix failing CI test with BERT on TorchScript path
@gs-olive gs-olive requested a review from narendasan June 13, 2023 17:08
@gs-olive gs-olive self-assigned this Jun 13, 2023
@github-actions github-actions bot added the component: tests Issues re: Tests label Jun 13, 2023
@gs-olive gs-olive requested a review from peri044 June 13, 2023 18:27
peri044
peri044 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 95e9a1b into pytorch:main Jun 13, 2023
@gs-olive gs-olive deleted the bert_ci_fix branch June 13, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels
cla signed component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @peri044 @facebook-github-bot