Skip to content

fix: Repair flaky TopK core test #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix: Repair flaky TopK core test #2022

merged 1 commit into from
Jun 14, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Update test code to generate a random unique sequence of integers for TopK comparison testing, avoiding index and value collisions in the results which were causing CI test failures

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
    • CI verification
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Repair flaky TopK core test
e5d46d8 
- Update test code to generate a random unique sequence of integers for
TopK comparison testing, avoiding index and value collisions in the
results which were causing CI test failures
@gs-olive gs-olive requested a review from narendasan June 14, 2023 21:39
@gs-olive gs-olive self-assigned this Jun 14, 2023
@github-actions github-actions bot added the component: tests Issues re: Tests label Jun 14, 2023
narendasan
narendasan approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 82631fa into pytorch:main Jun 14, 2023
@gs-olive gs-olive deleted the topk_flaky_test_fix branch June 15, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot