Skip to content

fix: Improve logging and kwarg passing in Dynamo #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix: Improve logging and kwarg passing in Dynamo #2052

merged 1 commit into from
Jun 28, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Improve kwarg passing through Dynamo frontend
  • Improve logging in case of TRT compilation failures

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels Jun 22, 2023
@gs-olive gs-olive requested a review from peri044 June 22, 2023 17:46
@gs-olive gs-olive self-assigned this Jun 22, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jun 22, 2023
@github-actions github-actions bot requested a review from narendasan June 22, 2023 17:46
gs-olive
gs-olive commented Jun 22, 2023
View reviewed changes
py/torch_tensorrt/dynamo/backend/__init__.py
Comment on lines +126 to +130
return partial(
torch_tensorrt_backend,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default backend now takes kwargs instead of compilation settings.

@gs-olive gs-olive force-pushed the dynamo_compile_logger_improvements branch from 4e9c484 to e465b7b Compare June 22, 2023 20:09
narendasan
narendasan reviewed Jun 22, 2023
View reviewed changes
@gs-olive gs-olive requested a review from narendasan June 22, 2023 23:02
@gs-olive gs-olive force-pushed the dynamo_compile_logger_improvements branch 2 times, most recently from e7a197d to 3747887 Compare June 27, 2023 05:11
@gs-olive
fix: Improve logging and kwarg passing in Dynamo
30ef927 
- Improve kwarg passing through Dynamo frontend
- Improve logging in case of TRT compilation failures
@gs-olive gs-olive force-pushed the dynamo_compile_logger_improvements branch from 3747887 to 30ef927 Compare June 28, 2023 19:34
@gs-olive gs-olive merged commit c2a2f61 into pytorch:main Jun 28, 2023
@gs-olive gs-olive deleted the dynamo_compile_logger_improvements branch June 28, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 Awaiting requested review from peri044

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot