Dynamo converter support for torch.ops.aten.erf.default op #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:30.255742 +0000
+++ py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:47.940338 +0000
@@ -105,6 +105,6 @@
name: str,
input_val: TRTTensor,
) -> TRTTensor:
return convert_unary(
network, target, source_ir, name, trt.UnaryOperation.ERF, input_val
- )
\ No newline at end of file
+ )
--- tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:30.271743 +0000
+++ tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:51.635953 +0000
@@ -19,6 +19,6 @@
expected_ops={torch.ops.aten.erf.default},
)
if __name__ == "__main__":
- run_tests()
\ No newline at end of file
+ run_tests()
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:32.723785 +0000
+++ py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:51.305560 +0000
@@ -105,6 +105,6 @@
name: str,
input_val: TRTTensor,
) -> TRTTensor:
return convert_unary(
network, target, source_ir, name, trt.UnaryOperation.ERF, input_val
- )
\ No newline at end of file
+ )
--- tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:32.743787 +0000
+++ tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:55.515767 +0000
@@ -19,6 +19,6 @@
expected_ops={torch.ops.aten.erf.default},
)
if __name__ == "__main__":
- run_tests()
\ No newline at end of file
+ run_tests()
|
@bowang007 run the linter |
gs-olive
reviewed
Aug 15, 2023
bowang007
force-pushed
the
dynamo_erf_converter
branch
from
f25c41f to
3c4c2fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR support dynamo converter for
torch.erfChecklist: