Skip to content

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Aug 8, 2023

Description

  • Remove arguments not present in initial schema for embedding
  • Improve coverage of embedding operator by expanding set of convertible implementations
  • Update parameter-checking function accordingly

Note: Reflects this embedding schema.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • Existing embedding tests
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added Story: ATen Op Support component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 8, 2023
@gs-olive gs-olive requested review from narendasan and apbose August 8, 2023 17:23
@gs-olive gs-olive self-assigned this Aug 8, 2023
@gs-olive gs-olive changed the title fix: Update embedding to reflect ATen schema fix: Update aten.embedding to reflect schema Aug 8, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters labels Aug 8, 2023
@github-actions github-actions bot requested a review from peri044 August 8, 2023 17:24
@github-actions github-actions bot requested a review from peri044 August 8, 2023 22:46
- Remove arguments not present in initial schema for embedding
- Improve coverage of embedding operator by expanding set of convertible
implementations
- Update parameter-checking function accordingly
@gs-olive gs-olive force-pushed the embedding_schema_fix branch from 670ff84 to ae553df Compare August 9, 2023 01:23
@gs-olive gs-olive requested a review from apbose August 14, 2023 18:52
@gs-olive gs-olive merged commit 06e544e into pytorch:main Aug 17, 2023
@gs-olive gs-olive deleted the embedding_schema_fix branch August 17, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: ATen Op Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants