Skip to content

fix: Repair broadcasting utility for aten.where #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Update logic in broadcasting utility to reflect differing ranks, including 0D tensors
  • Clean up code to reduce extra conditionals and variables
  • Add regression test case to aten.where suite

Fixes #2227

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths label Aug 14, 2023
@gs-olive gs-olive requested review from narendasan and apbose August 14, 2023 22:10
@gs-olive gs-olive self-assigned this Aug 14, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: tests Issues re: Tests labels Aug 14, 2023
@github-actions github-actions bot requested a review from peri044 August 14, 2023 22:10
- Update logic in broadcasting utility to reflect differing ranks,
including 0D tensors
- Add regression test case to `aten.where` suite
@gs-olive gs-olive merged commit e77e445 into pytorch:main Aug 17, 2023
@gs-olive gs-olive deleted the broadcastable_fix branch August 17, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Issue in broadcastable converter utility
3 participants