Skip to content

feat: support torch.ops.aten.sum.(default and dim_IntList) dynamo converter #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2023
Merged

feat: support torch.ops.aten.sum.(default and dim_IntList) dynamo converter #2278

merged 3 commits into from
Sep 1, 2023

Conversation

zewenli98
Copy link
Collaborator

Description

Support torch.ops.aten.sum.dim_IntList dynamo converter

Fixes #2244

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Aug 29, 2023
@github-actions github-actions bot requested a review from peri044 August 29, 2023 22:46
narendasan
narendasan reviewed Aug 30, 2023
View reviewed changes
py/torch_tensorrt/dynamo/conversion/impl/reduce.py Outdated
@@ -33,3 +33,29 @@ def amax(
)
set_layer_name(layer, target, name, source_ir)
return layer.get_output(0)


def sum_dim_IntList(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems over specialized, what are the other variants of sum? Can we combine the implementations?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narendasan Thanks for your suggestion! I updated to support both aten.sum.default and aten.sum.dim_IntList.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narendasan lmk if more changes are needed! thanks!

@zewenli98 zewenli98 changed the title feat: support torch.ops.aten.sum.dim_IntList dynamo converter feat: support torch.ops.aten.sum.(default and dim_IntList) dynamo converter Aug 31, 2023
@gs-olive gs-olive self-requested a review September 1, 2023 18:39
gs-olive
gs-olive approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gs-olive gs-olive merged commit c04a9da into pytorch:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@gs-olive gs-olive gs-olive approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement converter for torch.ops.aten.sum.dim_IntList
4 participants
@zewenli98 @narendasan @gs-olive @facebook-github-bot