Skip to content

Conversation

gs-olive
Copy link
Collaborator

  • Versioning does not recognize 2.1.0+cu118 as equal to 2.1.0. Switch implementation to use less-than comparison

@gs-olive gs-olive self-assigned this Sep 12, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile labels Sep 12, 2023
@github-actions github-actions bot requested a review from peri044 September 12, 2023 18:26
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 10917bf into main Sep 12, 2023
@gs-olive gs-olive deleted the minor_packaging_fix branch September 12, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants