Skip to content

feat: Add maxpool lowering passes and experimental folder in Dynamo #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

feat: Add maxpool lowering passes and experimental folder in Dynamo #2358

merged 1 commit into from
Oct 3, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Oct 2, 2023

Description

  • Add lowering pass to switch indices variants to non-indices variants
  • Add testing for lowering passes
  • Remove unused directory

Fixes #2357

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Oct 2, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests component: torch_compile labels Oct 2, 2023
@github-actions github-actions bot requested a review from narendasan October 2, 2023 19:32
github-actions[bot]
github-actions bot approved these changes Oct 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive changed the title feat: Add maxpool lowering pass indices feat: Add maxpool lowering passes and experimental folder in Dynamo Oct 2, 2023
github-actions[bot]
github-actions bot approved these changes Oct 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive force-pushed the maxpool_lowering_pass branch from a43552b to a18ae4c Compare October 2, 2023 20:44
github-actions[bot]
github-actions bot approved these changes Oct 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive force-pushed the maxpool_lowering_pass branch from a18ae4c to da6d733 Compare October 2, 2023 23:57
github-actions[bot]
github-actions bot approved these changes Oct 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

gs-olive
gs-olive commented Oct 3, 2023
View reviewed changes
@gs-olive
feat: Add maxpool lowering pass indices
d76d60a 
- Add lowering pass to switch `indices` variants to non-`indices`
variants
- Add testing for lowering passes
- Remove unused directory
@gs-olive gs-olive force-pushed the maxpool_lowering_pass branch from da6d733 to d76d60a Compare October 3, 2023 23:01
github-actions[bot]
github-actions bot approved these changes Oct 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive merged commit 4f72425 into main Oct 3, 2023
@gs-olive gs-olive deleted the maxpool_lowering_pass branch October 3, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests component: torch_compile priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maxpool Lowering passes
2 participants
@gs-olive @facebook-github-bot