Skip to content

cherry-pick: Safe mode and Build Arguments PRs #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

cherry-pick: Safe mode and Build Arguments PRs #2521

merged 2 commits into from
Dec 20, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Dec 8, 2023

Description

Type of change

  • Cherry-pick of two PRs

Checklist:

  • [ - ] My code follows the style guidelines of this project (You can use the linters)
  • [ - ] I have performed a self-review of my own code
  • [ - ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ - ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
  • [ - ] New and existing unit tests pass locally with my changes
  • [ - ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Dec 8, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation labels Dec 8, 2023
@github-actions github-actions bot requested a review from peri044 December 8, 2023 00:22
github-actions[bot]
github-actions bot approved these changes Dec 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive force-pushed the cherry_pick_safe_mode_build_args branch from 0ae138f to 80743b0 Compare December 20, 2023 19:40
github-actions[bot]
github-actions bot approved these changes Dec 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive merged commit b6dd22b into release/2.1 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gs-olive @facebook-github-bot