Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: Adding support for the uv system #3125

Merged
merged 2 commits into from
Sep 19, 2024
Merged

tool: Adding support for the uv system #3125

merged 2 commits into from
Sep 19, 2024

Conversation

narendasan
Copy link
Collaborator

Description

Adds a uv lock file and some settings that allows users to use uv out of the box to trivially build the main branch with just uv + bazel.

The uv.lock file should be regularly updated, there is a precommit job we could add for this but I want to test the workflow first before requiring people to install uv

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added documentation Improvements or additions to documentation component: build system Issues re: Build system labels Aug 29, 2024
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pyproject.toml Outdated
@@ -65,7 +65,7 @@ dependencies = [
dynamic = ["version"]

[project.optional-dependencies]
torchvision = ["torchvision >=0.20.dev,<0.21.0"]
# torchvision = ["torchvision >=0.20.dev,<0.21.0"] # Causes a bunch of issues with uv sync and tries to force install of a torch from June
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this issue is only related to uv.
when use pip it is not a iisue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you use pip doesnt look at torchvision until you ask for the torchvision extra dep, I think thats the issue

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com>
@github-actions github-actions bot removed the component: api [C++] Issues re: C++ API label Sep 18, 2024
@narendasan narendasan merged commit 1bf97a4 into main Sep 19, 2024
67 checks passed
@narendasan narendasan deleted the uv_env branch September 19, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: build system Issues re: Build system documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants