-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool: Adding support for the uv system #3125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pyproject.toml
Outdated
@@ -65,7 +65,7 @@ dependencies = [ | |||
dynamic = ["version"] | |||
|
|||
[project.optional-dependencies] | |||
torchvision = ["torchvision >=0.20.dev,<0.21.0"] | |||
# torchvision = ["torchvision >=0.20.dev,<0.21.0"] # Causes a bunch of issues with uv sync and tries to force install of a torch from June |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this issue is only related to uv.
when use pip it is not a iisue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you use pip doesnt look at torchvision until you ask for the torchvision extra dep, I think thats the issue
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com>
Description
Adds a uv lock file and some settings that allows users to use uv out of the box to trivially build the main branch with just
uv
+bazel
.The uv.lock file should be regularly updated, there is a precommit job we could add for this but I want to test the workflow first before requiring people to install
uv
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: