Skip to content

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Jul 1, 2025

Description

Fixes #3631

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia
Copy link
Collaborator

@HolyWu
I was stuck on this issue, thanks for raising the PR, it helped a lot.
I have a question about this:
I know build requires this env script, we never has this on test previously.
Do you know if it is anything new introduced from upstream torch?
Why it only fails the dynamo core tests, does not fail other tests?

@narendasan narendasan requested a review from lanluo-nvidia July 1, 2025 18:35
@HolyWu
Copy link
Contributor Author

HolyWu commented Jul 1, 2025

I suspect it's an upstream change in PyTorch too. But I don't know what combination will cause the compilation though.

@lanluo-nvidia lanluo-nvidia merged commit 99ffe1a into pytorch:main Jul 2, 2025
72 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Windows dynamo core tests failed
3 participants