Moe support #3811
Open
Moe support #3811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
cehongwang
force-pushed
the
moe-support
branch
from
22edfe6 to
fa53986
Compare
cehongwang
force-pushed
the
moe-support
branch
from
fa53986 to
6ea89ae
Compare
peri044
reviewed
Sep 24, 2025
There was a problem hiding this comment.
Could you add detailed comments demonstrating what it does now that you've gone through the entire converter ? that would be helpful
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
cehongwang
force-pushed
the
moe-support
branch
from
9e7ca5d to
c286767
Compare
narendasan
reviewed
Oct 7, 2025
| gm.graph.erase_node(node) | ||
| gm = clean_up_graph_after_modifications(gm) | ||
|
|
||
| gm = clean_up_graph_after_modifications(gm) |
There was a problem hiding this comment.
Is this just because we only need one cleanup?
There was a problem hiding this comment.
Yeah or otherwise it could take forever
peri044
reviewed
Oct 7, 2025
Comment on lines
+198
to
+203
| # param( | ||
| # test_name="4d_indices_none_none_multiple_idx_broadcast_error", | ||
| # source_tensor=torch.zeros([1, 2, 5, 3], dtype=torch.float32), | ||
| # indices_tensor=(None, None, torch.tensor([0, 1, 2], dtype=torch.int64)), | ||
| # value_tensor=torch.randn([2, 3, 3], dtype=torch.float32), | ||
| # ), |
There was a problem hiding this comment.
Consider mentioning the limitations of this converter and why this case is not supported ?
Comment on lines
+282
to
+286
| class Model(torch.nn.Module): | ||
| def forward(self, x, y, z, a, b): | ||
| x.index_add_(0, y, z) | ||
| x.index_add_(0, a, b) | ||
| return x |
There was a problem hiding this comment.
Does this testcase produce index_put ops ? or how is this connected ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: