Allow cpu and gpu in int4wo and int4wo-gptq quantizer #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Do we need to release a 0.1.1 for this? |
cpuhrsch
approved these changes
Apr 12, 2024
it's fine, this is for torchat, and it will be using torchao-nightly. I'll still looking at some perf issue for this, I'll merge after that |
cpuhrsch
reviewed
Apr 12, 2024
| @@ -762,11 +762,15 @@ def _check_linear_int4_k(k, groupsize = 1, inner_k_tiles = None): | |||
| return k_divisible_by_groupsize | |||
|
|
|||
| def linear_forward_int4(x, weight_int4pack, scales_and_zeros, out_features, groupsize): | |||
There was a problem hiding this comment.
So these conversions to bfloat16 are primarily needed because of _weight_int4pack_mm?
There was a problem hiding this comment.
yes, that's correct
Summary: att Test Plan: verified in torchat Reviewers: Subscribers: Tasks: Tags:
|
looks like there is no perf issues, I'll just merge |
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: att Test Plan: verified in torchat Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att
Test Plan:
verified in torchat
Reviewers:
Subscribers:
Tasks:
Tags: