Lint fixes test/quantization #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1359
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f64be84 with merge base 22bec74 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jainapurva
added
the
topic: not user facing
jerryzh168
approved these changes
Nov 28, 2024
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
…ed values (pytorch#1359) * Update cli.py to make --device/--dtype pre-empt quantize dict-specified values Users may expect that cli parameters override the JSON, as per pytorch#1278. Invert logic - case split: 1 - if none (no value) is specified, use value specified in quantize dict, if present; else 2 - if value is specified, override the respective handler if present. * Fix typo in cli.py fix typo --------- Co-authored-by: Jack-Khuu <jack.khuu.7@gmail.com>
andrewor14
reviewed
Dec 13, 2024
| Int4WeightOnlyQATQuantizer, | ||
| Int8DynActInt4WeightQATLinear, | ||
| Int8DynActInt4WeightQATQuantizer, | ||
| ) |
There was a problem hiding this comment.
Hey @jainapurva, should we add these back? The test is for checking the imports specifically
andrewor14
added a commit
that referenced
this pull request
Dec 13, 2024
Summary: The unused imports in this test were mistakenly deleted in #1359. This commit adds them back. Test Plan: python test/quantization/test_qat.py
andrewor14
added a commit
that referenced
this pull request
Dec 13, 2024
Summary: The unused imports in this test were mistakenly deleted in #1359. This commit adds them back. Test Plan: python test/quantization/test_qat.py
andrewor14
added a commit
that referenced
this pull request
Dec 13, 2024
Summary: The unused imports in this test were mistakenly deleted in #1359. This commit adds them back. Test Plan: python test/quantization/test_qat.py
amdfaa
pushed a commit
that referenced
this pull request
Jan 10, 2025
Summary: The unused imports in this test were mistakenly deleted in #1359. This commit adds them back. Test Plan: python test/quantization/test_qat.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected lint errors and added lint check to test/quantization folder