-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve profiler implementation and add comprehensive tests #1992
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1992
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 10 PendingAs of commit 668f776 with merge base 42e1345 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request improves the profiler implementation and adds comprehensive tests for profiling functionality.
- Refactors the profiler code to use a cached device variable and a warm-up phase for more consistent measurements.
- Adjusts profiler settings to reduce overhead by disabling stack traces and memory profiling.
- Introduces new tests to verify basic, CUDA, and memory profiling outputs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
benchmarks/microbenchmarks/utils.py | Updates profiler configuration and refactors device check. |
benchmarks/microbenchmarks/test/test_benchmark_profiler.py | Adds comprehensive tests for profiler and memory profiling. |
No description provided.