Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve profiler implementation and add comprehensive tests #1992

Closed
wants to merge 1 commit into from

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Apr 1, 2025

No description provided.

[ghstack-poisoned]
@jainapurva
Copy link
Contributor Author

jainapurva commented Apr 1, 2025

Copy link

pytorch-bot bot commented Apr 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1992

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 10 Pending

As of commit 668f776 with merge base 42e1345 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2025
@jainapurva jainapurva marked this pull request as draft April 1, 2025 20:01
@jainapurva jainapurva requested a review from Copilot April 1, 2025 20:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the profiler implementation and adds comprehensive tests for profiling functionality.

  • Refactors the profiler code to use a cached device variable and a warm-up phase for more consistent measurements.
  • Adjusts profiler settings to reduce overhead by disabling stack traces and memory profiling.
  • Introduces new tests to verify basic, CUDA, and memory profiling outputs.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
benchmarks/microbenchmarks/utils.py Updates profiler configuration and refactors device check.
benchmarks/microbenchmarks/test/test_benchmark_profiler.py Adds comprehensive tests for profiler and memory profiling.

@jainapurva jainapurva closed this Apr 1, 2025
jainapurva added a commit that referenced this pull request Apr 1, 2025
)

ghstack-source-id: a5f8301acb77a180a395aa8dd4c1aa9c2ccd7522
ghstack-comment-id: 2770609971
Pull Request resolved: #1997
jainapurva added a commit that referenced this pull request Apr 4, 2025
)

ghstack-source-id: a5f8301acb77a180a395aa8dd4c1aa9c2ccd7522
ghstack-comment-id: 2770609971
Pull Request resolved: #1997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants