Skip to content

Update float8nocompile test code to use new float8 matmul function #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Update float8nocompile test code to use new float8 matmul function #2013

merged 1 commit into from
Apr 4, 2025

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Apr 3, 2025 •
edited
Loading

Summary

  • The function name has changed since this test was originally written, so it needs to be updated now.
  • Confirmed test passes locally on H100
  • Float8nocompile prototype tests do not run in CI currently because they are flaky on sm89, so that's why this wasn't caught earlier

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2013

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit da3053d with merge base 76ec450 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2025
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Apr 3, 2025
@danielvegamyhre danielvegamyhre merged commit 0231a68 into main Apr 4, 2025
18 of 20 checks passed
jainapurva pushed a commit that referenced this pull request Apr 8, 2025
@danielvegamyhre @jainapurva
Update float8nocompile test code to use new float8 matmul function (#…
5409515 
…2013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielvegamyhre @jerryzh168 @facebook-github-bot