Fix quant_primitive dtype that caused perf regression #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/253
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0219109 with merge base 5741aa2 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: API call in quantize_activation_per_token_absmax is not exactly preserving the original code, this PR fixes that Test Plan: need to check perf with torchbenchmarks Reviewers: Subscribers: Tasks: Tags:
jerryzh168
force-pushed
the
fix-quant-primitive
branch
from
a70cf68
to
44676e6
Compare
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: API call in quantize_activation_per_token_absmax is not exactly preserving the original code, this PR fixes that Test Plan: need to check perf with torchbenchmarks Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
API call in quantize_activation_per_token_absmax is not exactly preserving the original code, this PR fixes that
Test Plan:
need to check perf with torchbenchmarks
Reviewers:
Subscribers:
Tasks:
Tags: