Skip to content

Conversation

@metascroy
Copy link
Contributor

Reverts #2938

This is failing internal tests with compile error. Please remove the unused variable qtype and reland, see #2972.

@pytorch-bot pytorch-bot bot added the ci-no-td label Sep 10, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2974

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Sep 10, 2025
@jerryzh168 jerryzh168 merged commit 83e8e60 into main Sep 10, 2025
16 of 20 checks passed
@Xia-Weiwen
Copy link
Collaborator

Hi @jerryzh168 @metascroy Sorry for the issue you met with the code. We are going to resubmit a PR. However, I have a few questions about this reversion:

Thanks.

@jerryzh168
Copy link
Contributor

for "Why not landing this PR #2972 instead of reverting the entire #2938?"

it's because many internal tests are failing so would be hard to verify if the fix is enough or not one by one

@jerryzh168
Copy link
Contributor

error is:

8: error: unused variable 'qtype' [-Werror,-Wunused-variable]
  177 |   auto qtype = qweight.scalar_type();
      |        ^~~~~
1 error generated.

@Xia-Weiwen
Copy link
Collaborator

Got it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants