Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NF4Tensor] Switch to save for backward since are now a tensor input #323

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Jun 4, 2024

Summary

Originally nf4tensor was not a tensor subclass, now that it is we update the autograd function to correctly save tensors for backwards. This may cause issues with torch.compile + autograd function.

Copy link

pytorch-bot bot commented Jun 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/323

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a6f03c1 with merge base 338d87c (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2024
@msaroufim msaroufim merged commit 08fb8bf into main Jun 5, 2024
12 of 13 checks passed
@msaroufim msaroufim deleted the add-switch-to-save-for-backward branch June 5, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants