-
Notifications
You must be signed in to change notification settings - Fork 376
Revert "Revert "[Reland][CPU] Add ops for float8 linear" (#3179)" #3254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 30082cb.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3254
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 460208e with merge base 9266734 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
CC @mingfeima for review. Thanks. |
|
Hi @vkuzo @jerryzh168 Do you think we can land this now? Thanks. |
|
Hi @vkuzo @jerryzh168 Would you mind if we land this now? It's not the cause of building errors on Windows. Thanks. |
|
sorry for the delay |
|
Thanks. |
…" (pytorch#3254) This reverts commit 30082cb.
This reverts commit 30082cb.
The commit was reverted because of #3175. However, the issue was not caused by this commit but a bug in
setup.py. And the issue will be fixed via #3187.So, this PR re-apply the commit that was reverted.
Original PR: #3100 and #3052
Test plan