-
Notifications
You must be signed in to change notification settings - Fork 368
update toy model to use global variants #3331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Jerry Zhang <jerryzh168@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3331
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
cc @jerryzh168 :) |
|
@pytorchbot label "topic: not user facing" "topic: for developers" |
|
I think we can prioritize |
Actually the order is intentional for the small-to-large process. So the order will be:
|
|
OK, please check the CI errors |
|
@pytorchbot label "topic: not user facing" "topic: for developers" |
Done, please take a look at this PR. |
Summary:
This PR is smaller chunks of #2729. Instead of implementing a linear model in each test code, we want to support its API for developers' utility and consistency. The updated toy model requires device and dtype to help clearly identify.
Test Plan:
benchmarks/benchmark_aq.py
test/dtypes/test_affine_quantized_float.py
Future Plan:
For a full update, we also have to update the following tests, the same as this PR:
Co-authored-by: Jerry Zhang jerryzh168@gmail.com