-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all dependencies except torch #369
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/369
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 10cd6b0 with merge base 664f073 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
dev-requirements.txt
Outdated
|
||
# For prototype features and benchmarks | ||
bitsandbytes #needed for testing triton quant / dequant ops for 8-bit optimizers | ||
matplotlib | ||
pandas | ||
fire # QOL for commandline scripts | ||
tabulate # QOL for printing tables to stdout | ||
numpy # mx benchmarks leverage benchmark timer which uses numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another timer that could be used?
That being said I can't remember if numpy is a dependency of torch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy is not supposed to be a dependency of torch but I've seen that assumption broken multiple times - I remember chatting about this with @malfet at some point too
That said the reason why this is needed is because of pytorch/pytorch#128759 which fixes the problem but only in 2.5+ lol
And yes we could just use another timer and drop this dependency completely even from our dev dependencies - although I really need to be writing docs tomorrow so would rather do this in a future PR unless @vkuzo gets to it first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I could also just remove the numpy dependency from dev dependencies because it's only used for a benchmark for mx that doesn't run in CI
* clean up req.txt * yolo * yolo * yolo * yolo * yolo * yolo * Update dev-requirements.txt * Delete requirements.txt * Update utils.py * Update README.md * Trigger CI * remove req from ci * Update doc_build.yml * remove numpy as a dependency * yolo * Update dev-requirements.txt * Update setup.py
Tested locally import torchao which works fine and CI is working fine
Packaging logic also works fine
We can also get rid of torch as a dependency, work is tracked here #371
CI failure is unrelated and will get fixed when we merge #377 so will rebase this PR before merge