Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing scripts #395

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fixing scripts #395

merged 1 commit into from
Jun 18, 2024

Conversation

HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Jun 18, 2024

Summary:

a few bugfixes for scripts

  1. convert_hf_checkpoint.py had a gpt-fast dependency that wasn't caught
    due to it being in the path. (caught here: Issues with the gptfast setup scripts #393)

  2. eval.py had a bug due to the switch to aqt apis

Test Plan:

python eval.py
wikitext: {'word_perplexity,none': 12.212490471702079, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.59675331009031, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6751414412399839, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}

python eval.py -q int8dq --compile
wikitext: {'word_perplexity,none': 12.253535794972834, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.597755518273052, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6760466701188526, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}

python eval.py -q int8wo --compile
wikitext: {'word_perplexity,none': 12.210618271188853, 'word_perplexity_stderr,none': 'N/A', 'byte_perplexity,none': 1.5967075310980392, 'byte_perplexity_stderr,none': 'N/A', 'bits_per_byte,none': 0.6751000785125764, 'bits_per_byte_stderr,none': 'N/A', 'alias': 'wikitext'}

python eval.py -q int4wo-64 --compile

python eval.py -q int4wo-64-gptq --compile

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jun 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/395

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3fa636f with merge base cb3bd8c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2024
Summary:

a few bugfixes for scripts

1) convert_hf_checkpoint.py had a gpt-fast dependency that wasn't caught
   due to it being in the path

2) eval.py had a bug due to the switch to aqt apis
3) generate.py had a bug due to the deprecation of the old quant apis

Test Plan:

python eval.py
python eval.py -q int8dq --compile --limit 2
python eval.py -q int8wo --compile --limit 2
python eval.py -q int4wo-64 --compile --limit 2
python eval.py -q int4wo-64-gptq --compile
sh benchmarks.sh

(going to add the output results once they finish

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link
Collaborator

@vayuda vayuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@vayuda vayuda merged commit 6b0ca2d into main Jun 18, 2024
13 checks passed
@HDCharles
Copy link
Contributor Author

HDCharles commented Jun 18, 2024

@vayuda this PR still had testing in progress and has some issues, please review->let owner merge if possible, rather than review->merge, just so any final changes can be made.

dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
Summary:

a few bugfixes for scripts

1) convert_hf_checkpoint.py had a gpt-fast dependency that wasn't caught
   due to it being in the path

2) eval.py had a bug due to the switch to aqt apis
3) generate.py had a bug due to the deprecation of the old quant apis

Test Plan:

python eval.py
python eval.py -q int8dq --compile --limit 2
python eval.py -q int8wo --compile --limit 2
python eval.py -q int4wo-64 --compile --limit 2
python eval.py -q int4wo-64-gptq --compile
sh benchmarks.sh

(going to add the output results once they finish

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants