fix bug with float8 + inference_mode #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As titled, just needed to add `reshape` to supported ops. Test Plan: ``` pytest test/float8/test_base.py -s -x -k inference_mode ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/659
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0e874fb with merge base 9eef1ae ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
approved these changes
Aug 12, 2024
drisspg
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
I am surprised this works without: pytorch-labs/float8_experimental#251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix #643
As titled, just needed to add
reshapeto supported ops.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: