Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Perf Profiler Update #690

Merged
merged 33 commits into from
Aug 16, 2024
Merged

Conversation

jeromeku
Copy link
Collaborator

@msaroufim

Same as #495 except rebased on main.

Copy link

pytorch-bot bot commented Aug 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/690

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b39443a with merge base 7f0621d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2024
@jerryzh168
Copy link
Contributor

@jeromeku really happy to see you updating this again, we were just discussing about this today. I think this is very important work and hope to merge this soon, I think one major thing before merging here is just to integrate the PERF_COUNTER etc. in torchao/_models/llama/perf_profile.py directly with https://github.com/pytorch/ao/blob/main/torchao/_models/llama/generate.py so we don't have duplications

cc @msaroufim @HDCharles

@msaroufim msaroufim self-requested a review August 16, 2024 01:09
@msaroufim
Copy link
Member

Let's do code unification in a later PR

Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@msaroufim msaroufim merged commit 0b66ff0 into pytorch:main Aug 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants