Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new evaluation metrics #934

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add new evaluation metrics #934

merged 1 commit into from
Sep 30, 2024

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Sep 24, 2024

Added new tests to llama/eval.sh for more extensive testing on larger metrics

Copy link

pytorch-bot bot commented Sep 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/934

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d0743e1 with merge base 72d2518 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2024
@jerryzh168
Copy link
Contributor

jerryzh168 commented Sep 24, 2024

if not sure if all eval metrics are relevant for llama quant, cc @HDCharles to take a look

@HDCharles
Copy link
Contributor

we can already specify any number of tasks with the --tasks argument, normally if I wanted to make it easier to run a small set of hard coded sets of experiments i would write an sh file that specified these things, not modify the lower level eval runner to have multiple ways to specify the tasks.

the current solution is specifying all tests explicitly in benchmarks.sh and we made evals.sh to do the same though I haven't added all the tests there yet. If you want to make it easier to run those sets i'd maybe add them there?

Is this a larger suggestion that the benchmarks we list in the README should be changed as well?

Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@jainapurva
Copy link
Contributor Author

the current solution is specifying all tests explicitly in benchmarks.sh and we made evals.sh to do the same though I haven't added all the tests there yet. If you want to make it easier to run those sets i'd maybe add them there?

I think we need more eval metrics to test the different techniques on llama. Though that could be done by updating the eval.sh instead. Also, we can add more benchmarks to the readme file in future.

@jainapurva jainapurva force-pushed the add_eval_metrics branch 3 times, most recently from 5776bc0 to c87a56d Compare September 27, 2024 02:49
@jainapurva jainapurva marked this pull request as ready for review September 27, 2024 16:05
@drisspg
Copy link
Contributor

drisspg commented Sep 27, 2024

@HDCharles just to confirm this is what you have in mind right?

Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks better

@jainapurva jainapurva merged commit ae49375 into main Sep 30, 2024
17 checks passed
melvinebenezer pushed a commit to melvinebenezer/ao that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants