Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer download CommonVoice directly #1018

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Nov 10, 2020

CommonVoice requests a user agreement before downloading, see here.

  • raise an error if url is not None
  • raise an error if download is True, and a warning if False

This also bumps default version to cv-corpus-5.1-2020-06-22 which is the latest available, since the previous is no longer available.

This should be cherry picked for 0.7.1.

@vincentqb vincentqb changed the title no longer allow to download CommonVoice directly no longer download CommonVoice directly Nov 10, 2020
@cpuhrsch
Copy link
Contributor

I suggest we follow the conventions for imagenet.

@vincentqb vincentqb force-pushed the commonvoice branch 3 times, most recently from 1d70472 to e9311b8 Compare November 20, 2020 19:40
deprecate: download and url. add language.
@vincentqb vincentqb merged commit 09a6fca into pytorch:master Dec 3, 2020
@vincentqb
Copy link
Contributor Author

vincentqb commented Dec 3, 2020

cc @seemethere for 0.7.1 release, #1065

vincentqb added a commit to vincentqb/audio that referenced this pull request Dec 3, 2020
no longer allow to download the dataset directly. deprecate: download and url. add language.
mthrok added a commit that referenced this pull request Dec 7, 2020
@mthrok mthrok mentioned this pull request Dec 7, 2020
@mthrok mthrok mentioned this pull request Dec 9, 2020
5 tasks
mthrok added a commit to mthrok/audio that referenced this pull request Dec 9, 2020
mthrok added a commit that referenced this pull request Dec 11, 2020
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Revert "Add mps device (pytorch#1018)"

This reverts commit 616caed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants