Publish artifacts on build_docs CircleCI job to get rendered html files #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
changed the title
|
Artifacts are now properly uploaded: https://app.circleci.com/pipelines/github/pytorch/audio/5212/workflows/226d6a04-f11b-447a-b26b-0ac535afa4ae/jobs/171661/artifacts |
|
@NicolasHug -- I'm assuming this needs to be cherry-picked in the release branch, is that correct? |
|
I don't think it's needed, as we probably don't need to see the artifacts on the release branch? |
|
@NicolasHug Thanks! It's been already super helpful #1322 |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
…ndows platform (pytorch#1321) * Update tutorial to tell user that TcpStore has been enabled on Windows * Resolve review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1316 (comment)
Docs are currently built but the artifacts aren't published so they generated html files aren't accessible. This PR fixes that.