Update config.guess for lame and libmad #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on 676fb0b Full Logs
Checking: |
@discort Thanks for help. Looks like the patch works. I think that the warning about C++ extension not found is because the package is installed in standard Python library location but you are still in torchaudio repo where torchaudio source code without the built extension is located, which shadows the installed package. I think if you moved out of the repo, the warning should be gone. |
vincentqb
approved these changes
May 25, 2021
There was a problem hiding this comment.
The evidences provided look reasonable to me. Stamped.
- Do you have a link to where this version of
config.guesswas taken/modified from? [EDIT: from Torchaudio Installation Jetson Aarch System #658 here, right?] - How will the patch be applied to new versions of lame?
- Does this close Torchaudio Installation Jetson Aarch System #658?
See https://www.gnu.org/software/gettext/manual/html_node/config_002eguess.html
I am not sure what you mean. Is there a particular version you are referring to?
Ideally, it should be closed with a CI test. But the build process has been changed since the issue is opened so we should move on and expect a new issue to be opened if this change stops working. |
|
Thanks! |
I saw the timestamp
|
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
config.guessfor lame and mad so that torchaudio can be built on Jetson.