Remove reuse_logits_for_grads option for RNNTL #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
force-pushed
the
rnntl-remove-reuse-logits
branch
from
af06d0e to
27690ec
Compare
This was referenced Jun 28, 2021
vincentqb
approved these changes
Jul 8, 2021
| rtol=rtol, | ||
| err_msg=f"failed on b={b}, t={t}/T={T}, u={u}/U={U}", | ||
| ) | ||
| with self.subTest(): |
There was a problem hiding this comment.
nit: subTest is no longer needed since there is only one test to run
carolineechen
force-pushed
the
rnntl-remove-reuse-logits
branch
from
0802145 to
326e34d
Compare
carolineechen
force-pushed
the
rnntl-remove-reuse-logits
branch
from
326e34d to
d55aed7
Compare
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Add generic join tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following discussion in #1532 and #1536, we are removing the
reuse_logits_for_gradoption for RNNT loss, as this results in modifying inputs in place and is not the usual behavior of a loss function