[fbsync] Resolve lint warning #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbshipit-source-id: 4fb853c391900d3070b936e5a3e4609eb78a780d
Summary: [10:30:47: cpuhrsch@devvm3140 pytorch]$ ./fb_build/import_audio.sh Reviewed By: vincentqb Differential Revision: D21282421 fbshipit-source-id: 9bde1455ca6a19defbf33dbbfc5f0d49a8e4dc6a
Summary: Import Up to pytorch#664 Reviewed By: cpuhrsch Differential Revision: D21728204 fbshipit-source-id: 648dd622087fa762194ca5f89a310500e777263d
Summary: Turned out .use_external_sox is not necessary for building torchaudio in fbcode. Reviewed By: vincentqb Differential Revision: D21792939 fbshipit-source-id: c0fb5173c6533e67114f50ddc8e9425bd129574f
Summary: import torchaudio 0.5.0 in fbcode using import_audio.sh: Reviewed By: vincentqb Differential Revision: D21884426 fbshipit-source-id: b6f2cc308e597caef2dd767c315b167c09fb0d4c
Summary: The previous implementation of parameterized testing worked by modifying test.common_utils inplace. This doesn't work in general because unittest's contract with test modules is such that it must be able to load the module and run the test itself. Because the previous implementation needed to load the module and modify it, it is incompatible. Reviewed By: mthrok Differential Revision: D21964676 fbshipit-source-id: 9bb71e8c3f9fab074239b22306f3bbddb0f3975b
Summary: Import torchaudio up to pytorch#719 Reviewed By: zhangguanheng66 Differential Revision: D22119491 fbshipit-source-id: e14842278a32c9373179fc132e8111a0ffe66d93
Summary: Pull Request resolved: pytorch#784 - Import torchaudio. - Change test util module name from test_case_utils to case_utils Reviewed By: cpuhrsch Differential Revision: D22261638 fbshipit-source-id: eb4df500c1d7db0a60baa100dd22795a63851438
fbshipit-source-id: 5113fe0c527595e4227ff827253b7414abbdf7ac
fbshipit-source-id: 798decc90db4f13770e97cdce3c0df7d5421b2a3
Summary: Import torchaudio 20200723 pytorch#814 Reviewed By: fmassa Differential Revision: D22666393 fbshipit-source-id: 50df07b5c158fe4e95ada7ea54381b2e26f6aecd
Summary: Raise and assert used to have a hard-coded error message "Exception". User provided error message was ignored. This PR adds support to represent user's error message in TorchScript. This breaks backward compatibility because now we actually need to script the user's error message, which can potentially contain unscriptable expressions. Such programs can break when scripting, but saved models can still continue to work. Increased an op count in test_mobile_optimizer.py because now we need aten::format to form the actual exception message. This is built upon an WIP PR: pytorch/pytorch#34112 by driazati Pull Request resolved: pytorch/pytorch#41907 Reviewed By: ngimel Differential Revision: D22778301 Pulled By: gmagogsfm fbshipit-source-id: 2b94f0db4ae9fe70c4cd03f4048e519ea96323ad
Summary: Up to pytorch#804 Reviewed By: vincentqb Differential Revision: D22947671 fbshipit-source-id: d1a005cec2f1a00913c41eda380b9f4b993ef779
Reviewed By: ashwinp-fb Differential Revision: D22955630 fbshipit-source-id: f00ef17a905e4c7cd9196c8924db39f9cdfe8cfa
Reviewed By: cpuhrsch Differential Revision: D23273584 fbshipit-source-id: 2fe7effa11b7f7cdf0cee1da6b1cac5556e9f55b
Summary: Up to pytorch#914 Reviewed By: vincentqb, cpuhrsch Differential Revision: D23846718 fbshipit-source-id: 9feb4e58563b900965467bd9ff66c979211c50df
Summary: this fixes some regressions introduced by D24121305. fairseq configuration is changing from command line to dataclasses (via hydra eventually) which no longer supports option aliases. one such alias is --max-sentences / --batch-size, and D24121305 removed --max-sentences as --batch-size is more appropriate (fairseq is not just an nlp framework dealing with sentences). unfortunately it seems some existing flows broke and this diff attempts to fix this Differential Revision: D24142488 fbshipit-source-id: 075180ea10a9d706a3f8d64b978d66dfd83c3d2b
Reviewed By: cpuhrsch Differential Revision: D24606263 fbshipit-source-id: 4301b1df84d20c671783ec34c52d5b257374abf1
Summary: Import torchaudio up to pytorch#1004 5e54c77 Reviewed By: vincentqb, cpuhrsch Differential Revision: D24841498 fbshipit-source-id: 3829130636f36779d84f01ff0d0120b80b2396d7
Summary: Import torchaudio pytorch#1027 0cf4b8a Reviewed By: vincentqb, cpuhrsch Differential Revision: D24958707 fbshipit-source-id: d06dd6b59197cc2c16bec5a9012cbf33a172b6b3
Summary: Import up to pytorch#1066 Reviewed By: cpuhrsch Differential Revision: D25373068 fbshipit-source-id: 890d36a25259b93428b3037c3123ff5a2cacfa04
Summary: Import torchaudio up to pytorch#1105 37692d8 Reviewed By: datumbox Differential Revision: D25671497 fbshipit-source-id: 5af11c801321f2bb964245ac6ed74979310f4b5f
Summary: Import torchaudio pytorch#1161 7a36c55 Reviewed By: cpuhrsch Differential Revision: D25827050 fbshipit-source-id: 31e07ace85f7e1417884cd721bc80c5c6c33960f
Summary: Import torchaudio pytorch#1639 37dbf29 Reviewed By: carolineechen, mthrok Differential Revision: D29920658 fbshipit-source-id: 94ba8c04edcfb50e355b1ca8e937f612917ecf38
Summary: Moving the fb-specific logic to `fb` directory, so that it is no longer visible in OSS (well, unless one dig the commit history) Reviewed By: carolineechen, nateanl Differential Revision: D30080845 fbshipit-source-id: 85b04dab2d362e94110a9ce90f54523a49b6fc74
Summary: Import torchaudio pytorch#1620 af652ca Reviewed By: nateanl, mthrok Differential Revision: D30079698 fbshipit-source-id: 9ade6df7bd006782f146a04dfdbd4549981cb001
Summary: For the case where torchaudio is used with `mode/opt`, D29973934 introduced extension initialization module specific for fbcode and the override process. This diff simplifies the process by just inserting the step to extract extension module as a regular file at the beginning of torchaudio extension initialization process, so that OSS and fbcode use the same process / code. Reviewed By: carolineechen Differential Revision: D29989551 fbshipit-source-id: 9f30d0a36c220f0eb669244c9bb2da1b833d6f03
Summary: To address the test failure in T96406395 Reviewed By: carolineechen Differential Revision: D30163741 fbshipit-source-id: f88d86b3da7b1ee52518934567b0b0a62700ee58
Summary: The stress test still fails. Add n_fft to address it. Reviewed By: mthrok Differential Revision: D30218279 fbshipit-source-id: 7858efd3e5ac0073193a7883fd314486efc73814
Summary: title Reviewed By: nateanl Differential Revision: D30304880 fbshipit-source-id: 7b9c5ab6fbc06266c8421f1fdc0217effbc7e609
Summary: as titled Reviewed By: carolineechen Differential Revision: D30449599 fbshipit-source-id: 7b3faaf6d7dbfa2e5ca9c263554b18e7364be77e
Summary: Import torchaudio up to pytorch#1726 560c082 Reviewed By: carolineechen Differential Revision: D30579288 fbshipit-source-id: 324cf0eb089786605e1a10e5f44f8114424dd0a6
Summary: import torchaudio pytorch#1734 e8cc7f9 Reviewed By: nateanl, mthrok Differential Revision: D30675712 fbshipit-source-id: 0529dde7e94d53e5ba1b386ab66b6f8eb73ba079
Summary: Import torchaudio pytorch#1755 e11d27c Reviewed By: carolineechen Differential Revision: D30844075 fbshipit-source-id: 1295cc142dda23cb4b029b332b4ef78bb0a67432
Summary: Update reference from master to main elsewhere in fbcode Reviewed By: alexeib Differential Revision: D30938472 fbshipit-source-id: 243b98550207f241c9d3265bf3d4060350aaf0a8
Summary: Import torchaudio by commit pytorch@40f2a08 Reviewed By: carolineechen Differential Revision: D31056614 fbshipit-source-id: b04e83fe5460faad8f5d106da44a6e0f3aa2756b
Summary: title Reviewed By: nateanl, mthrok Differential Revision: D31271175 fbshipit-source-id: d0b6c44d71a4434fa75e6cd481724632dbd1a3ae
Summary: Pull Request resolved: pytorch#1817 This changes the imports in the `torchaudio` to include the new import locations. ``` codemod -d pytorch/audio --extensions py 'torch.quantization' 'torch.ao.quantization' ``` Reviewed By: mthrok Differential Revision: D31302450 fbshipit-source-id: f31a0d4f453f840ea690edb688555a9d585787b5
Summary: title Reviewed By: carolineechen Differential Revision: D31476921 fbshipit-source-id: c790146b133921de8bbda67c8e8c7a1b321b4bd4
Reviewed By: mthrok Differential Revision: D31728916 fbshipit-source-id: 4b932f285c274c5f2197325ce73ecbd930e3597e
Summary: title Reviewed By: nateanl, mthrok Differential Revision: D31997978 fbshipit-source-id: cfbfa192780f7d786a658eb84cc0685881a4f398
mthrok
approved these changes
Nov 3, 2021
nateanl
approved these changes
Nov 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.