Packaging improvements for nightlies #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instructions for how to install stable and master binaries, without hardcoding wheel filenames - Turn on Python 2 build (numba is only needed for testing) - Make builds a little more hermetic - Prefer building against nightly CPU-only torch build - Don't install all of requirements.txt, it's not necessary Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
ezyang
added a commit
that referenced
this pull request
Aug 1, 2019
Based off of #198 but nightly specific changes were dropped. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
soumith
approved these changes
Aug 1, 2019
Contributor
|
I prefer to have the requirements in a file just for visibility (maybe packaging_requirements.txt). The current requirements.txt has a bunch of test dependencies like librosa, etc. which is used in the CI |
Contributor
Author
Sure, and this PR doesn't remove requirements.txt. It just stops using them for wheel builds. |
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
jamarshon
added a commit
to jamarshon/audio
that referenced
this pull request
Aug 1, 2019
* Packaging improvements for nightlies - Instructions for how to install stable and master binaries, without hardcoding wheel filenames - Turn on Python 2 build (numba is only needed for testing) - Make builds a little more hermetic - Prefer building against nightly CPU-only torch build - Don't install all of requirements.txt, it's not necessary - Updates for OS X too, including portability issues Signed-off-by: Edward Z. Yang <ezyang@fb.com> (cherry picked from commit 4542332)
ezyang
pushed a commit
that referenced
this pull request
Aug 2, 2019
* Packaging improvements for nightlies - Instructions for how to install stable and master binaries, without hardcoding wheel filenames - Turn on Python 2 build (numba is only needed for testing) - Make builds a little more hermetic - Prefer building against nightly CPU-only torch build - Don't install all of requirements.txt, it's not necessary - Updates for OS X too, including portability issues Signed-off-by: Edward Z. Yang <ezyang@fb.com> (cherry picked from commit 4542332)
ezyang
added a commit
that referenced
this pull request
Aug 2, 2019
Based off of #198 but nightly specific changes were dropped. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without hardcoding wheel filenames
Signed-off-by: Edward Z. Yang ezyang@fb.com