Set release version and base PyTorch version for 1.11 pytorch release #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atalman
approved these changes
Feb 9, 2022
| fi | ||
| echo "export UPLOAD_CHANNEL=${our_upload_channel}" >> ${BASH_ENV} | ||
| # Hardcoded for release branch | ||
| echo "export UPLOAD_CHANNEL=test" >> ${BASH_ENV} |
There was a problem hiding this comment.
Since we on the release branch, why is this change required ? It should automatically use test, correct ?
There was a problem hiding this comment.
According to @mthrok : Even though UPLOAD_CHANNEL is set to test if the branch name is release/*, when you are making a PR against the release branch, the value of CIRCLE_BRANCH is something like pr/XXX, and the CI jobs of PRs against release branches use nightly builds.
There was a problem hiding this comment.
That's correct. We need this for invoking signal for CI like. CicleCI's spec could have changed but it's safe to hard code this.
There was a problem hiding this comment.
Got it! Thanks for explanation.
mthrok
approved these changes
Feb 9, 2022
atalman
changed the title
|
close and re-open to trigger the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ppdate circle ci torchaudio/pytorch versions for release