Add rtf_evd method to torchaudio.functional #2230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
reviewed
Feb 16, 2022
mthrok
reviewed
Feb 16, 2022
There was a problem hiding this comment.
We should have a test against some reference, so that when the implementation is changed, we know it produces similar values from the original implementation.
If it is hard to hand-compute reference values, we can use NumPy, so that implementation won't change.
nateanl
force-pushed
the
refactor_mvdr_3
branch
from
4809773 to
e953ab3
Compare
nateanl
changed the title
mthrok
approved these changes
Feb 25, 2022
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
force-pushed
the
refactor_mvdr_3
branch
3 times, most recently
from
9deebbf to
0f849f3
Compare
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This PR adds `rtf_evd` method to `torchaudio.functional`. The method computes the relative transfer function (RTF) or the steering vector by eigenvalue decomposition. The input argument is the power spectral density (PSD) matrix of the target speech. Pull Request resolved: pytorch#2230 Reviewed By: mthrok Differential Revision: D34474188 Pulled By: nateanl fbshipit-source-id: cbd8c883d7a4576c5e735334a470ae3016126f8d
nateanl
force-pushed
the
refactor_mvdr_3
branch
from
0f849f3 to
f25a7a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34474188 |
11 tasks
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: This PR adds `rtf_evd` method to `torchaudio.functional`. The method computes the relative transfer function (RTF) or the steering vector by eigenvalue decomposition. The input argument is the power spectral density (PSD) matrix of the target speech. Pull Request resolved: pytorch#2230 Reviewed By: mthrok Differential Revision: D34474188 Pulled By: nateanl fbshipit-source-id: 888df4b187608ed3c2b7271b34d2231cdabb0134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
rtf_evdmethod totorchaudio.functional.The method computes the relative transfer function (RTF) or the steering vector by eigenvalue decomposition.
The input argument is the power spectral density (PSD) matrix of the target speech.