Refactor eval and pipeline_demo scripts in emformer_rnnt #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
approved these changes
Feb 15, 2022
hwangjeff
reviewed
Feb 16, 2022
| @@ -1,3 +1,8 @@ | |||
| """The demo script for testing the pre-trained Emformer RNNT pipelines. | |||
There was a problem hiding this comment.
can we also add RawTextHelpFormatter as in the other script?
There was a problem hiding this comment.
Yes, it's addressed in #2239
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
force-pushed
the
rnnt_mustc_pipeline_2
branch
from
291c497 to
803b64f
Compare
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
force-pushed
the
rnnt_mustc_pipeline_2
branch
from
803b64f to
e7ec4f6
Compare
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: - Add docstring to `eval.py` and `pipeline_demo.py` under `emformer_rnnt` directory. - Refactor logger and ArgumentParser Pull Request resolved: pytorch#2238 Reviewed By: mthrok Differential Revision: D34267059 Pulled By: nateanl fbshipit-source-id: 4b8d3d183ee7bc0ad71ce305cab87bfa90208b2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval.pyandpipeline_demo.pyunderemformer_rnntdirectory.